[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

This revision was automatically updated to reflect the committed changes. Closed by commit rG92d8ad02e92f: [HIP] Fix rocm not found on rocm3.5 (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D81713?vs=270298&id=271689#toc Repository: rG

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl added a comment. I will commit this patch since it allows hipcc to use old rocm device library. Will fix other issues later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 ___ cfe-commits ma

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. This only solves compatability with the old layout in the case where the hipcc wrapper is pointing directly to the library directory. I think this will still fail with the native clang search

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2090309 , @arsenm wrote: > > I can tell that it does not. We're still looking under `/opt/rocm` by > > default. I've ran into it trying to get comgr working with the recent LLVM > > which prompted my comment on Github > >

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2090265 , @tra wrote: > In D81713#2089760 , @arsenm wrote: > > > In D81713#2089680 , @yaxunl wrote: > > > > > In D81713#2089672

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2089760 , @arsenm wrote: > In D81713#2089680 , @yaxunl wrote: > > > In D81713#2089672 , @arsenm wrote: > > > > > Can you add tests for this? Is

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. In D81713#2089680 , @yaxunl wrote: > In D81713#2089672 , @arsenm wrote: > > > Can you add tests for this? Is this also sufficient with the directory > > layout change? > > > You mean does th

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl added a comment. In D81713#2089672 , @arsenm wrote: > Can you add tests for this? Is this also sufficient with the directory layout > change? You mean does this work after we move device lib from /opt/rocm/lib to /opt/rocm/amdgcn/bitcode ? CHA

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

arsenm added a comment. Can you add tests for this? Is this also sufficient with the directory layout change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 ___ cfe-commits mailing list cfe-commits

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

yaxunl created this revision. yaxunl added reviewers: tra, arsenm. Herald added subscribers: kerbowa, nhaehnle, wdng, jvesely. Currently rocm detector expects device library bitcodes named as *.bc instead of *.amdgcn.bc. However in rocm3.5 the device library bitcodes are named as *.amdgcn.bc, whic