arsenm added a comment. In D81713#2090265 <https://reviews.llvm.org/D81713#2090265>, @tra wrote:
> In D81713#2089760 <https://reviews.llvm.org/D81713#2089760>, @arsenm wrote: > > > In D81713#2089680 <https://reviews.llvm.org/D81713#2089680>, @yaxunl wrote: > > > > > In D81713#2089672 <https://reviews.llvm.org/D81713#2089672>, @arsenm > > > wrote: > > > > > > > Can you add tests for this? Is this also sufficient with the directory > > > > layout change? > > > > > > > > > You mean does this work after we move device lib from /opt/rocm/lib to > > > /opt/rocm/amdgcn/bitcode ? > > > > > > Yes > > > I can tell that it does not. We're still looking under `/opt/rocm` by > default. I've ran into it trying to get comgr working with the recent LLVM > which prompted my comment on Github > <https://github.com/llvm/llvm-project/commit/123bee602a260150ff55c74287f583a67ee78f36#r39817848> Not sure how that would be related to comgr? comgr doesn't rely on the dynamic path and embeds the bitcode in the library. The comgr build finds the libraries through cmake and doesn't care where they're located CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81713/new/ https://reviews.llvm.org/D81713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
