This revision was automatically updated to reflect the committed changes.
Closed by commit rG512e256c0d8c: [PowerPC] Add clang options to control MMA
support (authored by bsaleil).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81442/new/
https://rev
bsaleil updated this revision to Diff 281381.
bsaleil added a comment.
Update diff so it can be applied to master.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81442/new/
https://reviews.llvm.org/D81442
Files:
clang/include/clang/Driver/Options
amyk accepted this revision.
amyk added a comment.
I think overall it LGTM.
Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:44
// Do not support QPX (Quad Processing eXtension), SPE (Signal Processing
// Engine), prefixed instructions on Power 9, PC relative mem ops,
bsaleil updated this revision to Diff 277858.
bsaleil added a comment.
Add test to check that the `mma` option is supported by the targets.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81442/new/
https://reviews.llvm.org/D81442
Files:
clang/inc
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
Since clang will now add `+/-mma` to the TargetFeatures list, please add a test
case that specifies `-mattr=+/-mma` to `llc` to show that `llc` accepts it.
Other than that, LGTM.
Reposito
bsaleil updated this revision to Diff 277580.
bsaleil added a comment.
Herald added subscribers: llvm-commits, hiraditya.
Also add target options with this patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81442/new/
https://reviews.llvm.org/D814
bsaleil updated this revision to Diff 277466.
Herald added a subscriber: dang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81442/new/
https://reviews.llvm.org/D81442
Files:
clang/include/clang/Driver/Options.td
clang/lib/Basic/Targets/PPC.cpp
