[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

2020-06-08 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG936ec89e91e2: [AST] Fix a clang crash on an invalid for-range statement. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81384?vs=269188

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

2020-06-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked 2 inline comments as done. hokein added inline comments. Comment at: clang/test/SemaCXX/for-range-crash.cpp:6 + Bar *variables_to_modify; + foo() { // expected-error {{C++ requires a type specifier for all declarations}} +for (auto *c : *variables_to_modify

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

2020-06-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/for-range-crash.cpp:6 + Bar *variables_to_modify; + foo() { // expected-error {{C++ requires a type specifier for all declaratio

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

2020-06-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2437 if (RequireCompleteType(RangeLoc, RangeType, -diag::err_for_range_incomplete_type)) +diag::err_for_rang

[PATCH] D81384: [AST] Fix a clang crash on an invalid for-range statement.

2020-06-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. crash stack: llvm-project/clang/lib/AST/ASTContext.cpp:2248: clang::TypeInfo clang::ASTContext::getTypeInfoImpl(const clang::Type *) const: Assertion `!A->getDeducedType().isNull() && "cannot requ