sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/test/SemaCXX/for-range-crash.cpp:6
+  Bar<int> *variables_to_modify;
+   foo() {  // expected-error {{C++ requires a type specifier for all 
declarations}}
+    for (auto *c : *variables_to_modify)
----------------
What's the significance of the missing return type here? Can we add void)

Can we move this function out of the class?

(In both cases just to remove any confusion about what the problematic pattern 
actually is)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81384/new/

https://reviews.llvm.org/D81384



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to