[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. In D80522#2082095 , @teemperor wrote: > This introduced a compiler warning: > > > /Users/teemperor/1llvm/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: > warning: 'getDecl' ov

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

teemperor added a comment. This introduced a compiler warning: /Users/teemperor/1llvm/llvm-project/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1102:23: warning: 'getDecl' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] cons

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG98db1f990fc2: [Analyzer] [NFC] Parameter Regions (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80522?vs=268131&id=269477#toc Repository: rG LLVM Github Monorepo

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:404-407 /// Returns memory location for a parameter variable within the callee stack /// frame. May fail; returns null on failure. - const VarRegion *getParameterLocat

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + baloghadamsoftware wrote: > NoQ wrote: > > What's the point of overriding one pure virtual met

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + NoQ wrote: > What's the po

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 268131. baloghadamsoftware added a comment. Comment fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h clang/include/clan

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! I like how it turned out, i guess let's prefer this to D79704 . Comment at: clang/include/clang/StaticAnalyzer/Core/PathSens

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. > I will check tomorrow whether we could remove `DeclRegion` without too much > code duplication. It turns out that `DeclRegion` is used in 7 different checkers plus in `BugReporterVisitor`s. One typical us

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917 assert(isa(sReg) || isa(sReg) || isa(sReg) || isa(sReg)); } balaz

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266851. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. Updated according to the comments of @balazske. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Fil

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917 assert(isa(sReg) || isa(sReg) || isa(sReg) || isa(sReg)); } This assert should not be duplicated. It has the place in `VarRegion

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added a comment. In D80522#2055040 , @NoQ wrote: > Nice, looks like you managed to reuse most of the code. I still feel like we > should ditch `DeclRegion` entirely (forcing its ~5 cu

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266298. baloghadamsoftware added a comment. Herald added a subscriber: wuzish. Wrong diff uploaded previously, now fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 Files: clang/include/cla

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware updated this revision to Diff 266296. baloghadamsoftware added a comment. Herald added subscribers: llvm-commits, MaskRay, hiraditya, arichardson, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added a project: LLVM. Updated accor

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

NoQ added a comment. Nice, looks like you managed to reuse most of the code. I still feel like we should ditch `DeclRegion` entirely (forcing its ~5 current users consider its specific variants separately) but i don't insist. Comment at: clang/include/clang/StaticAnalyzer/Che

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xaza

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

baloghadamsoftware added a comment. This is an alternative approach to D79704 . The advantage is that we must not duplicate code everywhere where `VarRegion` (and sometimes also `DeclRegion`) is used. The drawback is that after we implement handling of parameter