baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:921 +public: + const VarDecl *getDecl() const override = 0; + ---------------- NoQ wrote: > What's the point of overriding one pure virtual method with another pure > virtual method? To constrain the return value from `Decl` to `VarDecl`. Without this we have change all the callers to cast the return value from this function to `VarDecl`. It would be ugly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80522/new/ https://reviews.llvm.org/D80522 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
