[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall closed this revision. rjmccall added a comment. 8a8d703be0986dd6785cba0b610c9c4708b83e89 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.o

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. Thanks John. Would you be able to land this on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mai

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. Per a private discussion, it seems like the right thing to do here would be stop recognizing `-ffast-math` flag in cc1 and just put the driver in charge of all these individual flags. That may necessitate adding a `-fdefine-fast-math` cc1 option to control the `#defin

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267401. michele.scandale added a comment. Revert last change about `-ffast-math` imply "fast" contraction mode by default in CC1. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale requested review of this revision. michele.scandale added a comment. I've just realized it might be incorrect to have the CC1 option `-ffast-math` changing the default contraction mode. The clang driver generates `-ffast-math` based on conditions that do not involve the contract

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. >> I'm actually surprised it doesn't. I can't imagine why someone enabling >> fast math would want contraction to be disabled. > > Just to be clear the clang driver does the right thing.

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267124. michele.scandale added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fixup more tests with now redundant `-ffp-contract=fast` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 267121. michele.scandale added a comment. Rebase + `-ffast-math` change the default contraction mode to fast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 F

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2061164 , @rjmccall wrote: > In D80315#2059160 , > @michele.scandale wrote: > > > In D80315#2058914 , @rjmccall > > wrote: > > >

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. In D80315#2059160 , @michele.scandale wrote: > In D80315#2058914 , @rjmccall wrote: > > > In D80315#2058735 , > > @michele.scandale wrote: > > > >

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2058914 , @rjmccall wrote: > In D80315#2058735 , > @michele.scandale wrote: > > > In D80315#2058549 , @rjmccall > > wrote: > > >

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. In D80315#2058735 , @michele.scandale wrote: > In D80315#2058549 , @rjmccall wrote: > > > The code cleanups all seems reasonable. The actual changes in > > code-generation changes are be

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale added a comment. In D80315#2058549 , @rjmccall wrote: > The code cleanups all seems reasonable. The actual changes in > code-generation changes are because we were failing to set these reliably? Most of them yes. In the CUDA test we t

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

rjmccall added a comment. The code cleanups all seems reasonable. The actual changes in code-generation changes are because we were failing to set these reliably? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv float michele.scandale wrote: > This chan

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 265405. michele.scandale added a comment. Fix formatting issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

mibintc added a comment. Thanks for cleaning this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale updated this revision to Diff 265333. michele.scandale added a comment. Fix 'clang/test/CodeGenCUDA/library-builtin.cu' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80315/new/ https://reviews.llvm.org/D80315 Files: clang/includ

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale marked an inline comment as done. michele.scandale added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale marked 2 inline comments as done. michele.scandale added inline comments. Comment at: clang/test/CodeGen/libcalls.c:11-21 + // CHECK-FAST: call reassoc nsz arcp afn float @llvm.sqrt.f32(float float l0 = sqrtf(a0); // CHECK-YES: call double @sqrt // CH

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

michele.scandale created this revision. michele.scandale added reviewers: rjmccall, mibintc, Anastasia. Herald added subscribers: cfe-commits, jvesely. Herald added a project: clang. michele.scandale marked an inline comment as done. michele.scandale added inline comments. michele.scandale marked 2