[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

This revision was automatically updated to reflect the committed changes. Closed by commit rGe408cba84f8a: [AST] Mangle LambdaContextDecl for top level decl (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://rev

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 269882. zequanwu added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx17.cpp Index: clang/test/CodeGenCXX

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 267057. zequanwu added a comment. Don't mangle `ParmVarDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx17.cpp Index:

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265388. zequanwu edited the summary of this revision. zequanwu added a comment. Check `LambdaContextDecl` is not `ParamVarDecl`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/Micros

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

rnk added a comment. After looking at the code more, I'm more convinced that your fix is in the right place. Comment at: clang/lib/AST/MicrosoftMangle.cpp:954 if ((isa(LambdaContextDecl) || - isa(LambdaContextDecl)) && -LambdaContex

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265046. zequanwu added a comment. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp clang/test/CodeGenCXX/mangle-ms-cxx11.cpp clang/test/CodeG

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu updated this revision to Diff 265031. zequanwu added a comment. Remove check for context of `LambdaContextDecl`. Update test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80153/new/ https://reviews.llvm.org/D80153 Files: clang/lib/AST/MicrosoftMangle.cpp Index: clan

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified n

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified n

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified name. + // member (static or nonstatic)

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

zequanwu created this revision. zequanwu added reviewers: CaseyCarter, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45213 To resolve it, we could mangle the `LambdaContextDecl` if it is top level decl. Reposito