rnk added inline comments.

================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952
           // If the context of a closure type is an initializer for a class
-          // member (static or nonstatic), it is encoded in a qualified name.
+          // member (static or nonstatic) or is a top level decl, it is encoded
+          // in a qualified name.
----------------
Will this fix work if the inline variable is in a namespace, or inline function?

This code seems like maybe it should live in `getEffectiveDeclContext`. Are you 
sure the fix won't be there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80153/new/

https://reviews.llvm.org/D80153



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [P... Zequan Wu via Phabricator via cfe-commits
    • ... Reid "On Leave" Kleckner via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits
    • ... Reid "Away June-Sep" Kleckner via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits
    • ... Zequan Wu via Phabricator via cfe-commits

Reply via email to