dschuff added a comment.
Actually, would it be possible to not ignore `throw()` but make it an alias for
`noexcept(true)`? Apparently that is the standard behavior in C++17, so it
might make more sense to just implement that now rather than just warning all
the time and ignoring it. It would al
aheejin updated this revision to Diff 263218.
aheejin added a comment.
- Delete a debugging(?) line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79655/new/
https://reviews.llvm.org/D79655
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
aheejin marked an inline comment as done.
aheejin added inline comments.
Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399
+// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions
-fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature
+exception-handling
aheejin marked an inline comment as done.
aheejin added inline comments.
Comment at: clang/lib/CodeGen/CGException.cpp:23
#include "clang/AST/StmtVisitor.h"
+#include "clang/Basic/DiagnosticSema.h"
#include "clang/Basic/TargetBuiltins.h"
aheejin wrote:
> One th
aheejin marked an inline comment as done.
aheejin added inline comments.
Comment at: clang/lib/CodeGen/CGException.cpp:23
#include "clang/AST/StmtVisitor.h"
+#include "clang/Basic/DiagnosticSema.h"
#include "clang/Basic/TargetBuiltins.h"
One thing I'm not sure
aheejin created this revision.
aheejin added a reviewer: dschuff.
Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100.
Herald added a project: clang.
Wasm does not currently handle exception specifications such as
`throw()` or `throw(int)`. We have a plan to correctly implemen
