[PATCH] D78915: [clang-format] Improved parser for C# properties

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44ad58b9915d: [clang-format] Improved parser for C# properties (authored by Jonathan Coe ). Changed pri

[PATCH] D78915: [clang-format] Improved parser for C# properties

krasimir accepted this revision. krasimir added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe updated this revision to Diff 260599. jbcoe marked 3 inline comments as done. jbcoe added a comment. Added missing comments. Complied with LLVM style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 Files: clang/lib/Format/UnwrappedLine

[PATCH] D78915: [clang-format] Improved parser for C# properties

krasimir added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1508 bool HasGetOrSet = false; + bool IsTrivialPropertyAccessor = true; while (!eof()) { Add a comment illustrating is what is a trivial property accessor. CHANGES SINCE

[PATCH] D78915: [clang-format] Improved parser for C# properties

MyDeveloperDay added a comment. I think if this code is only used by C# which the first if suggests, we should be OK, just tidy up a bit with the old code and I think this is fine. Thank you, so great to have other C#'ers doing this ;-) "Clang format all the things..." Com

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe updated this revision to Diff 260316. jbcoe added a comment. Format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unitte

[PATCH] D78915: [clang-format] Improved parser for C# properties

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can you please clang-format the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.or

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added some examples of properties from Microsoft documentation as test cases. https://docs.microsoft.com/en-us/