MyDeveloperDay added a comment. I think if this code is only used by C# which the first if suggests, we should be OK, just tidy up a bit with the old code and I think this is fine.
Thank you, so great to have other C#'ers doing this ;-) "Clang format all the things..." ================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1513 Keywords.kw_set)) { - if (Tok->isOneOf(Keywords.kw_get, Keywords.kw_set)) + if (Tok->isOneOf(Keywords.kw_get, Keywords.kw_set)) { HasGetOrSet = true; ---------------- the style in LLVM is to not have braces on single line if statements. (not my style but we need to keep to it) ================ Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1563 + // --Line->Level; + nextToken(); + break; ---------------- you need to remove old code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits