[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

thakis added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]); ---

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG8000d506afcd: [clangd] Strip /showIncludes in clangd compile commands (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. In D78836#2003696 , @kadircet wrote: > thanks, lgtm. do you have commit access? Yep :) Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://r

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet accepted this revision. kadircet added a comment. thanks, lgtm. do you have commit access? Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") &&

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") {

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260103. aeubanks added a comment. Handle /showIncludes:user Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files: clang-tools-extra/clangd/unittests/CompileCommands

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]); -

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

kadircet added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]); -

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks updated this revision to Diff 260040. aeubanks added a comment. Add test in ToolingTest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 Files: clang-tools-extra/clangd/unittests/CompileCommandsTe

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler = CommandMangler::forTests(); sammccall wrote: > It'

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82 +TEST(CommandMangler, StripShowIncludes) { + auto Mangler = CommandMangler::forTes

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

aeubanks added a comment. Herald added a subscriber: ormris. I did verify that clangd on vscode now works on Windows on the LLVM codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78836/new/ https://reviews.llvm.org/D78836 _