sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:82
+TEST(CommandMangler, StripShowIncludes) {
+ auto Mangler = CommandMangler::forTests();
----------------
It's useful to have this test to verify the behavior at the clangd level, but
the arg adjuster is a separate library and also used in other contexts.
The unit-test for this arg-adjuster lives in
clang/unittests/Tooling/ToolingTest.cpp around line 500. Could you add a test
for the new behavior there, too?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78836/new/
https://reviews.llvm.org/D78836
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
