[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. Device library change submitted. 123bee602a260150ff55c74287f583a67ee78f36 CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:75 +// The desired structure is (${ROCM_ROOT} or +// ${OPENCL_ROOT})/amdgcn/bitcode/*, so try to detect this layout. yaxunl wrote:

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:75 +// The desired structure is (${ROCM_ROOT} or +// ${OPENCL_ROOT})/amdgcn/bitcode/*, so try to detect this layout. with your change, the structure becomes ${ROCM_ROOT}/a

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm added a comment. In D77885#1983708 , @yaxunl wrote: > If we really want to do this, device lib change and hipcc change need to be > ready. Since once this is committed without corresponding device lib and > hipcc change, HIP will break. The libr

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

yaxunl added a comment. If we really want to do this, device lib change and hipcc change need to be ready. Since once this is committed without corresponding device lib and hipcc change, HIP will break. On ROCM, device lib is currently installed at /opt/rocm/lib with extension .amdgcn.bc. This

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77885/new/ https://reviews.llvm.org/D77885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm updated this revision to Diff 256598. arsenm added a comment. Forgot to commit part CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77885/new/ https://reviews.llvm.org/D77885 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/Inputs/rocm-device-libs/amdgcn/bitcode

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

arsenm created this revision. arsenm added reviewers: yaxunl, b-sumner, hliao. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. The current install situation is a mess, but I'm working on fixing it. Search for the target layout instead of one of the N o