arsenm added a comment. In D77885#1983708 <https://reviews.llvm.org/D77885#1983708>, @yaxunl wrote:
> If we really want to do this, device lib change and hipcc change need to be > ready. Since once this is committed without corresponding device lib and > hipcc change, HIP will break. The library change is also waiting for review > On ROCM, device lib is currently installed at /opt/rocm/lib with extension > .amdgcn.bc. This change requires device libs to be installed to > /opt/rocm/amdgcn/bitcode and with extension .bc (drop amdgcn in extension). > Also in hipcc -device-lib-path option needs to point to > /opt/rocm/amdgcn/bitcode or dropped. HIP is fixed/merged with the CL handling in D76957 <https://reviews.llvm.org/D76957> > On Windows, device lib Makefiles need to be changed to drop amdgcn in > extension. > > Another issue: is /opt/rocm/amdgcn/bitcode the right installation path for > device lib? Shouldn't it be /opt/rocm/lib/amdgcn/bitcode or > /opt/rocm/lib/amdgcn ? These aren't host libraries, so I don't think these belong under /lib. CUDA installs the functionally equivalent in /usr/local/cuda/nvvm/libdevice/*.bc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77885/new/ https://reviews.llvm.org/D77885 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
