This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rGa975fde23a5e: [clang] Annotate trivial getters and setters
on hover. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D77408?vs=2548
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:376
+llvm::Optional fieldName(const Expr *E) {
+ const auto *ReturnedMember = llvm::dyn_cast(E->IgnoreCasts());
+ const auto *Field =
kad
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang-tools-extra/clangd/Hover.cpp:376
+llvm::Optional fieldName(const Expr *E) {
+ const auto *ReturnedMember = llvm::dyn_cast(E->IgnoreCasts(
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous.
Herald added a project: clang.
(Only if their definitions are visible and they have no other docs)
Repository:
rG LLVM Github Monorepo
https://reviews.ll
