sammccall marked 2 inline comments as done.
sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/Hover.cpp:376
+llvm::Optional<StringRef> fieldName(const Expr *E) {
+ const auto *ReturnedMember = llvm::dyn_cast<MemberExpr>(E->IgnoreCasts());
+ const auto *Field =
----------------
kadircet wrote:
> if(!ReturnedMember) return None
Oops, also forgot to check the base of the MemberExpr was CXXThisExpr.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77408/new/
https://reviews.llvm.org/D77408
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
