[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG29e1a16be821: [NFC] Let mangler accept GlobalDecl (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/AST/Expr.cpp:693 else - MC->mangleName(ND, Out); + GD = GlobalDecl(ND); +MC->mangleName(GD, Out); rjmccall wrote: > This will need an e

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:1563 + else +GD = GlobalDecl(dyn_cast(DC)); + return GD; rjmccall wrote: > `cast`? But I'm not sur

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl updated this revision to Diff 248926. yaxunl marked 6 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/inclu

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

rjmccall added inline comments. Comment at: clang/lib/AST/Expr.cpp:693 else - MC->mangleName(ND, Out); + GD = GlobalDecl(ND); +MC->mangleName(GD, Out); This will need an extension for your case, right? Maybe there should be co

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl updated this revision to Diff 248873. yaxunl added a comment. Remove mangleCXXCtor/Dtor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/include/clang/AST/Mangle.h clang/lib/AST/Expr

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { yaxunl wrote: > rjmccall wrote: > > What would be neces

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { rjmccall wrote: > What would be necessary in order for

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { What would be necessary in order for this to turn into just `mangleName(GD, Out)`? I suspec

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl created this revision. yaxunl added a reviewer: rjmccall. yaxunl added a child revision: D68578: [HIP] Fix device stub name. This change is separated from https://reviews.llvm.org/D68578 https://reviews.llvm.org/D75700 Files: clang/include/clang/AST/GlobalDecl.h clang/include/clang/A