rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/AST/ItaniumMangle.cpp:1563 + else + GD = GlobalDecl(dyn_cast<FunctionDecl>(DC)); + return GD; ---------------- rjmccall wrote: > `cast`? But I'm not sure this is true, local entities can be in non-function > declarations: blocks, ObjC methods, and captured statements. You can just > `cast<Decl>(DC)`. I guess we just never enter this for local names within ObjC methods or blocks? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75700/new/ https://reviews.llvm.org/D75700 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
