[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-03-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae2fc7a8bb3: [clangd] Get rid of lexer usage in locateMacroAt (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://revi

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-02-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 247439. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files: clang-tools-ex

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-02-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SourceCode.h:285 }; /// Gets the macro at a specified \p Loc. It must be a spelling location and /// point to the beginning of ide

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-02-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 247213. kadircet added a comment. - Update forgotten call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/ https://reviews.llvm.org/D75331 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

2020-02-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added reviewers: sammccall, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75259: [clangd] Get rid of unnecssary source transformations