This revision was automatically updated to reflect the committed changes.
Closed by commit rGe6b8181895b9: [clangd] Fix early selection for non-vardecl
declarators (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
http
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:612
+ // underlying TypeLoc.
+ // FIXME: Unfortunately this doesn't work, even though
RecursiveASTVisitor
+ // traverses the underlying TypeLoc inside DeclarationName, it is null
f
kadircet updated this revision to Diff 248123.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Add the old test for hover over operator back.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
https://reviews.llvm.org/D
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Selection.cpp:612
+ // underlying TypeLoc.
+ // FIXME: Unfortunately this doesn't work, even though
RecursiveASTVisi
kadircet updated this revision to Diff 246635.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
https://reviews.llvm.org/D75106
Files:
clang-tools-ex
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:615
+ if (isa(D))
+return SourceRange();
+ // This will capture Field, Function, MSProperty, NonTypeTemplateParm and
we may have to blacklist deduction guides to
kadircet updated this revision to Diff 246405.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75106/new/
https://reviews.llvm.org/D75106
Files:
clang-tools-ex
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:613
// int (*[[s]])();
- else if (auto *VD = llvm::dyn_cast(D))
-return VD->getLocation();
+ if (auto *DD = llvm::dyn_cast(D))
+return DD->getLocation();
-
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Selection tree was performing an early claim only for VarDecls, but
there are other cases where we can
