[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61663 tests passed, 0 failed and 779 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet updated this revision to Diff 237105. kadircet marked an inline comment as done. kadircet added a comment. - Use find_if instead of raw loop Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72458/new/ https://reviews.llvm.org/D72458 Files:

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

This revision was automatically updated to reflect the committed changes. Closed by commit rG189aa5b7a458: [clangd] Adjust diagnostic range to be inside main file (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72458/new/ https

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:342 +llvm::Optional NoteInsideMainFile; +for (auto &N : D.Notes) { + if (!N.InsideMainFile) ilya-biryukov wrote: > NIT: ar

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/Diagnostics.cpp:342 +llvm::Optional NoteInsideMainFile; +for (auto &N : D.Notes) { + if (!N.InsideMainFil

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61663 tests passed, 0 failed and 779 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72458: [clangd] Adjust diagnostic range to be inside main file

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. LSP requires diagnostics to lay inside main file. In clangd we keep diagnostics in three different cases: - alread