This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rG21b43885b81a: Fix bug 44190 - wrong code with #pragma
pack(1) (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES S
yaxunl updated this revision to Diff 233133.
yaxunl added a comment.
remove parenthesis
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71282/new/
https://reviews.llvm.org/D71282
Files:
clang/lib/CodeGen/CGCall.cpp
clang/test/CodeGen/s390x-packed-struct-func-arg.c
Index: clang/test
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:4008
+ if ((!ArgInfo.getIndirectByVal() ||
+ (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty
{
NeedCopy = true;
---
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:4008
+ if ((!ArgInfo.getIndirectByVal() ||
+ (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty
{
NeedCopy = true;
Thanks for the fix. Plea
yaxunl created this revision.
yaxunl added reviewers: rjmccall, efriedma, jnspaulsson.
https://github.com/llvm/llvm-project/commit/5b330e8d6122c336d81dfd11c864e6c6240a381e
caused
a regression on s390:
https://bugs.llvm.org/show_bug.cgi?id=44190
we need to copy if if either the argument is non-b
