[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. In D71213#1783467 , @nhaehnle wrote: > In D71213#1781322 , @gchatelet wrote: > > > LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a > > warning but it only works

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

nhaehnle added a comment. In D71213#1781322 , @gchatelet wrote: > LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a > warning but it only works when building without `-Wall`. Did you mean to write _with_ -Wall? I fail to see anyt

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. @foad do you have any insights on how to go with the deprecation? LLVM has this `LLVM_ATTRIBUTE_DEPRECATED` macro, it's convenient to get a warning but it only works when building without `-Wall`. Bots and in-tree users have it set by default, it's fine as I'll be fixi

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. >> Thx for letting me know @foad . I'll make sure to keep the old API with a >> deprecation message from now on. >> Do you have any other suggestions on how to make this less painful for >> out-of-tree users? I'm afraid that the cleanup phase (removal of deprecated >

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

foad added a comment. In D71213#1780088 , @gchatelet wrote: > In D71213#1779841 , @foad wrote: > > > @gchatelet in general would it be possible to make changes like this in a > > backwards-compatible way, or in two

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. In D71213#1779841 , @foad wrote: > @gchatelet in general would it be possible to make changes like this in a > backwards-compatible way, or in two stages without a "flag day" change? We > have out-of-tree users of CreateMemSet

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

foad added a comment. @gchatelet in general would it be possible to make changes like this in a backwards-compatible way, or in two stages without a "flag day" change? We have out-of-tree users of CreateMemSet and it's awkward to change them all at exactly the same time as we merge in this chan

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b2842bf902a: [Alignment][NFC] CreateMemSet use MaybeAlign (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet added a comment. Thx for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet updated this revision to Diff 233074. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71213/new/ https://reviews.llvm.org/D71213 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBu

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet marked 2 inline comments as done. gchatelet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:2910 +const Align Alignment = +assumeAligned(cast(I.getArgOperand(2))->getZExtValue()); Value *Mask = I.getArgOperand(

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

courbet added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1092 const DataLayout &DL = F.getParent()->getDataLayout(); -unsigned IntptrAlignment = DL.getABITypeAlignment(MS.IntptrTy); +Align IntptrAlignment = Align(DL.getABITyp

[PATCH] D71213: [Alignment][NFC] CreateMemSet use MaybeAlign

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context: http