[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso added a comment. Thanks for the reviews! In D70411#2153562 , @Szelethus wrote: > Please do not bypass the previous comments that hadn't reached a conclusion > -- littering inlines about miscellaneous stuff at this stage does more harm > then go

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 278368. Charusso marked 18 inline comments as done. Charusso edited the summary of this revision. Charusso added a comment. - Resolve most of the review comments. - We really need to specify the design of future checkers. CHANGES SINCE LAST ACTION https:/

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Szelethus added a comment. Please do not bypass the previous comments that hadn't reached a conclusion -- littering inlines about miscellaneous stuff at this stage does more harm then good, and derails the discussion. Its not the first time I took a look, and I made some progress today again, b

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not nul

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:859 + +def Str31cChecker : Checker<"31c">, + HelpText<"SEI CERT checker of rules defined in STR31-C">, Maybe we could have more descriptive names for th

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt:21 CastValueChecker.cpp + cert/StrChecker.cpp CheckObjCDealloc.cpp Are there so many things common among checkers for SEI CERT string rules that the bes

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 265959. Charusso retitled this revision from "[analyzer] CERT: STR31-C" to "[analyzer] CERT STR rule checkers: STR31-C". Charusso added a comment. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411