baloghadamsoftware added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:859 + +def Str31cChecker : Checker<"31c">, + HelpText<"SEI CERT checker of rules defined in STR31-C">, ---------------- Maybe we could have more descriptive names for these checkers and mention the number of the rule in the `HelpText` only. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:66 + void checkStrcpy(const CallEvent &Call, const CallContext &CallC, + CheckerContext &C) const; + /// \} ---------------- I would avoid reusing the prefix `check` for functions that are not inherited from `Checker`. Alternatives could be `handle`, `process` etc. for modeling and `verify`, `validate` etc. for checking for error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
