[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith closed this revision. dexonsmith added a comment. Committed in bfd58fc60ff4b0c081b5b489119c3798d3e2b53c and 01782c3e4df1830d7991e9edfee9119ed41e4c27

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith marked an inline comment as done. dexonsmith added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4236 + MEnd = Loaded.end(); + M != MEnd; ++M) { +ModuleFile &F = *M->Mod; apran

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReader.cpp:4211 + // hit errors parsing the ASTs at this point. for (SmallVectorImpl::iterator M = Loaded.begin(),

[PATCH] D70056: clang/Modules: Split loop in ReadAST between failable and not

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. Split a loop in ReadAST that visits the just-loaded module chain, between an initial loop that reads further from the ASTs (and can fail) and a second loop that does some p