[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki abandoned this revision. miyuki added a comment. Abandoning in favor of D94237 and D94596 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 __

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

dexonsmith added a comment. In D69903#2342011 , @miyuki wrote: > In D69903#2340020 , @dexonsmith > wrote: > >> An alternative would be to update the unions to an `AlignedCharArrayUnion` >> and use `SourceLocation`

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki added a comment. In D69903#2340020 , @dexonsmith wrote: > An alternative would be to update the unions to an `AlignedCharArrayUnion` > and use `SourceLocation` directly. WDYT? So, say, in `DeclarationNameLoc`, I would add `AlignedCharArrayUnion` a

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. An alternative would be to update the unions to an `AlignedCharArrayUnion` and use `SourceLocation` directly. WDYT? Comment at: clang/include/clang/AST/Dec

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki updated this revision to Diff 249447. miyuki added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 Files: clang/include/clang/AST/DeclObjC.h clang/include/clang/AST/DeclarationName.h clang/include/clang/AST/Depend

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki created this revision. miyuki added reviewers: faisalv, rsmith, aprantl, JDevlieghere. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. miyuki added a parent revision: D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI. miyuki edited par