dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed.
An alternative would be to update the unions to an `AlignedCharArrayUnion` and use `SourceLocation` directly. WDYT? ================ Comment at: clang/include/clang/AST/DeclObjC.h:652-655 struct PODSourceRange { - unsigned Begin; - unsigned End; + PODSourceLocation Begin; + PODSourceLocation End; }; ---------------- IIRC, this will not be a POD, since the access of the members of `PODSourceRange` is `public` and the access of the members of `PODSourceLocation` is `private`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69903/new/ https://reviews.llvm.org/D69903 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits