[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG87e0cb4f1ad2: [clangd] Implement semantic highlightings via findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:220 + bool VisitOverloadExpr(OverloadExpr *E) { +if (!E->decls().empty()) + return true; // handle

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59845 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov updated this revision to Diff 227713. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Rename to LangOpts and SourceMgr - Rename to CollectExtraHighlightings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:220 + bool VisitOverloadExpr(OverloadExpr *E) { +if (!E->decls().empty()) + return true; // handled by findExplicitReferenc

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:194 + const SourceManager &SM; + const LangOptions &LO; + std::vector Tokens; nit: I'd call it `LangOpts` Comment at: clang-tools-extra/clangd/Semant

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59818 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69673: [clangd] Implement semantic highlightings via findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To keep the logic of finding locations of interesting AST nodes in one place. The advantage is better coverage of