[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

This revision was automatically updated to reflect the committed changes. ilya-biryukov marked an inline comment as done. Closed by commit rG733777a81662: [clangd] Fix namespace aliases in findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D69624#1728377 , @kadircet wrote: > As discussed offline, it might make more sense to fix this in `targetDecls` > itself. Considering how the `Alias` is handled for typedefs

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet added a comment. As discussed offline, it might make more sense to fix this in `targetDecls` itself. Considering how the `Alias` is handled for typedefs and usings, it feels like this is a mistake for namespace aliases to be marked in that way. Repository: rG LLVM Github Monorepo C

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. This looks good, but it is missing the context. I suppose we were previously not providing any references for namespace aliases, because we were filtering both the alias and the underlying

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59703 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69624 Files: clang-tools-extra/clangd/FindTarget.cpp