[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:453 + // and the clients are not prepared to handle that. + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().get

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

merge_guards_bot added a comment. Build result: pass - 59699 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c430a7c6f6b: [clangd] Do not report anonymous entities in findExplicitReferences (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:453 + // and the clients are not prepared to handle that. + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().getAsIdentifierInfo()) i believe this w

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FindTarget.cpp:454 + if (ND->getDeclName().isIdentifier() && + !ND->getDeclName().getAsIdentifierInfo()) +retur

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov added a comment. Stumbled upon it when trying to move semantic highlight to use `findExplicitReferences`. This will create some trouble for D68937 , but I believe it's actually worth it. `NameLoc` was never intended to point outside the name token.

[PATCH] D69511: [clangd] Do not report anonymous entities in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Otherwise every client dealing with name location should handle anonymous names in a special manner. This seems to