[PATCH] D69338: [clangd] Collect name references in the index.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf71e4fe0a68: [clangd] Collect name references in the index. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69338/new/ https://reviews.

[PATCH] D69338: [clangd] Collect name references in the index.

merge_guards_bot added a comment. Build result: fail - 59566 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69338: [clangd] Collect name references in the index.

hokein updated this revision to Diff 226139. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69338/new/ https://reviews.llvm.org/D69338 Files: clang-tools-extra/clan

[PATCH] D69338: [clangd] Collect name references in the index.

merge_guards_bot added a comment. Build result: fail - 59565 tests passed, 2 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: cmake-log.txt

[PATCH] D69338: [clangd] Collect name references in the index.

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:268 - // decide to implement renaming with index support. - if ((Roles & static_cast(index::SymbolRole::Nam

[PATCH] D69338: [clangd] Collect name references in the index.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:633 + Annotations Header(R"( +class $foo[[Foo]] { +public: --

[PATCH] D69338: [clangd] Collect name references in the index.

hokein created this revision. hokein added reviewers: kadircet, ilya-biryukov. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. This is used for cross-file rename. When renaming a class, we expect to rename all related constructors/destructors. Repo