This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ab6d8236b17: [clang-scan-deps] Add basic support for
modules. (authored by Bigcheese).
Changed prior to commit:
https://reviews.llvm.org/D68835?vs=225311&id=226352#toc
Repository:
rG LLVM Github Mon
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
@Bigcheese I don't have time right now to do the build experiments, so I'll
leave it as follow-up for me to resolve later. LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6883
Bigcheese updated this revision to Diff 225311.
Bigcheese added a comment.
Added .i, .ii, .mi, and .mmi as files to minimize.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68835/new/
https://reviews.llvm.org/D68835
Files:
lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cp
dexonsmith added inline comments.
Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135
+ return llvm::StringSwitch(Ext)
+.CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true)
+.CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true)
Bigcheese updated this revision to Diff 224507.
Bigcheese marked 2 inline comments as done.
Bigcheese added a comment.
Addressed review comments.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68835/new/
https://reviews.llvm.org/D68835
Files:
lib/Tooling/Depend
arphaman added inline comments.
Comment at: lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:135
+ return llvm::StringSwitch(Ext)
+.CasesLower(".c", ".cc", ".cpp", ".c++", ".cxx", true)
+.CasesLower(".h", ".hh", ".hpp", ".h++", ".hxx", true)
--
arphaman added inline comments.
Comment at: test/ClangScanDeps/modules.cpp:39
+// CHECK2: modules_cdb_input.cpp
+// CHECK2-NEXT: Inputs/module.modulemap
+// CHECK2-NEXT: Inputs{{/|\\}}header.h
Missing windows path slash thing.
Repository:
rC Clang
CHANGES SI
Bigcheese created this revision.
Bigcheese added a reviewer: arphaman.
Herald added subscribers: tschuett, dexonsmith.
Herald added a project: clang.
This fixes two issues that prevent simple uses of Clang modules from working.
- We would previously minimize _every_ file opened by clang, even mod
