[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-10 Thread Russell Gallop via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. russell.gallop marked an inline comment as done. Closed by commit rG9d9ac46a08d7: Remove rest of time-trace message as it is inconsistent style (authored by russell.gallop). Changed prior to commit: https://reviews.llvm.o

[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-10 Thread Anton Afanasyev via Phabricator via cfe-commits
anton-afanasyev accepted this revision. anton-afanasyev added a comment. This revision is now accepted and ready to land. Yes, I agree. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___ cfe-c

[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-10 Thread Russell Gallop via Phabricator via cfe-commits
russell.gallop updated this revision to Diff 224278. russell.gallop added a comment. Update so --help helps user find trace file. Documentation has the further details on how to view it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 Files: c

[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-10 Thread Russell Gallop via Phabricator via cfe-commits
russell.gallop marked 2 inline comments as done. russell.gallop added inline comments. Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tr

[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-09 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. besides that, I think we should do it; thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___ cfe-commits mailing list c

[PATCH] D68710: Remove time-trace message as it is inconsistent style

2019-10-09 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added inline comments. Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tracing or `Speedscope App " + "