russell.gallop marked 2 inline comments as done. russell.gallop added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tracing or `Speedscope App " + "<https://www.speedscope.app>`_ for flamegraph visualization." >, ---------------- sylvestre.ledru wrote: > I am not a big fan of adding products in the in-product help. > If Chrome removes the feature or Speedscope goes done, we will still list > that in the old version of clang. > Deprecated doc is more common and accepted. > > I would remove this line and the next line and keep the doc. > > I would remove this line and the next line and keep the doc. I agree. Updated to do that via the tablegen file. Removed the changes to the rst file which is generated from tablegen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
