This revision was automatically updated to reflect the committed changes.
Closed by commit rGedf5027689c5: [clang] Add test for FindNextToken in Lexer.
(authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews.llvm.org/D68565
__
usaxena95 updated this revision to Diff 223524.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Addressed comments and fixed build failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews.llvm.org/D68
ilya-biryukov added a comment.
Could you add a rationale in the change description? E.g. something like `we do
not have any tests for findNextToken`
Comment at: clang/unittests/Lex/LexerTest.cpp:559
+ }
+ EXPECT_EQ(ExpectedTokens, GeneratedByNextToken);
+}
N
usaxena95 updated this revision to Diff 223503.
usaxena95 added a comment.
Revert unintended formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews.llvm.org/D68565
Files:
clang/unittests/Lex/LexerTest.cpp
Index: c
usaxena95 created this revision.
usaxena95 added a reviewer: ilya-biryukov.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D68565
Files:
clang/unittests/Lex/LexerTest.cpp
Index: clang/unittests/Lex/LexerTes
