ilya-biryukov added a comment.
Could you add a rationale in the change description? E.g. something like `we do
not have any tests for findNextToken`
================
Comment at: clang/unittests/Lex/LexerTest.cpp:559
+ }
+ EXPECT_EQ(ExpectedTokens, GeneratedByNextToken);
+}
----------------
NIT: could be replaced with
```
EXPECT_THAT(GeneratedByNextToken, ElementsAre("abcd", "=", ....))
```
To avoid creating an extra variable.
But up to you, this version also looks ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68565/new/
https://reviews.llvm.org/D68565
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
