[PATCH] D68377: [Builtins] Teach Clang about memccpy

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfece0a108a7: [Builtins] Teach Clang about memccpy (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226761. xbolva00 added a comment. Newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeGen/builtin

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor testing nit. Comment at: clang/test/CodeGen/memccpy-libcall.c:13 +// CHECK: attributes #2 = { nobuiltin } \ No newline at end of file -

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226571. xbolva00 added a comment. Added new testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/CodeG

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 226570. xbolva00 added a comment. Addressed review note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: clang/include/clang/Basic/Builtins.def clang/test/C

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1698399 , @xbolva00 wrote: > Current solution does not work > /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: > error: redefinition of ‘BImemccpy’ > > #define BUILTIN(ID, TYPE, ATTRS)

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a comment. Ping @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 reclaimed this revision. xbolva00 added a comment. (still interested in this patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 abandoned this revision. xbolva00 added a comment. Abandoned since D67986 was abandoned too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 ___ cfe-commits

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a comment. Current solution does not work /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: error: redefinition of ‘BImemccpy’ #define BUILTIN(ID, TYPE, ATTRS) BI##ID, ^ /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: note:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a subscriber: RKSimon. xbolva00 added a comment. Hm, Maybe we have a bug in LLVM's TLI? TLI says Win32 has no memccpy. https://llvm.org/doxygen/TargetLibraryInfo_8cpp_source.html line 333 cc @RKSimon since he knows windows-related things more. CHANGES SINCE LAST ACTION https://

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 223441. xbolva00 added a comment. Added it for msvc too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.def test/CodeGen/builtin-memfns.c test/CodeGen/memccpy-libc

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 223440. xbolva00 added a comment. Added some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.def test/CodeGen/builtin-memfns.c test/CodeGen/memccpy-libcall.c

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GNU_LANGUAGES) xbolva00

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") a

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GNU_LANGUAGES) xbolva00

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:983 // POSIX string.h +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_GNU_LANGUAGES) LIBBUILTIN(stpcpy, "c*c*cC*", "f", "string.h", ALL_GN

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") a

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1693490 , @xbolva00 wrote: > It is not very obvious for me what kind of test should be done here. I > would be grateful if you could show me an example in tree. I was thinking of something in CodeGen, like Code

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added a comment. It is not very obvious for me what kind of test should be done here. I would be grateful if you could show me an example in tree. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. Test cases? Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") GCC doesn't seem to have `__bui

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 updated this revision to Diff 223017. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68377/new/ https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.def Index: include/clang/Basic/Builtins.def ===

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/Builtins.def:903 LIBBUILTIN(memcpy, "v*v*vC*z","f", "string.h", ALL_LANGUAGES) +LIBBUILTIN(memccpy, "v*v*vC*iz", "f", "string.h", ALL_LANGUAGES) LIBBUILTIN(me

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, kristina. Herald added a project: clang. Hopefully, -fno-builtin-memccpy will work now. Repository: rC Clang https://reviews.llvm.org/D68377 Files: include/clang/Basic/Builtins.