[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ marked 2 inline comments as done. NoQ added a comment. In D67419#1665993 , @Szelethus wrote: > Looks great! Are we sure that `PathDiagnostic.h` is a good header name? Not really, but i haven't come up with a better name yet (see also the summary of

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/F

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

Szelethus added a comment. Looks great! Are we sure that `PathDiagnostic.h` is a good header name? Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" --

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, mgorny. Herald added a project: clang. NoQ added a

[PATCH] D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" This needed to go up beca