gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:26 #include "clang/ASTMatchers/ASTMatchFinder.h" -#include "clang/Config/config.h" #include "clang/Format/Format.h" ---------------- Szelethus wrote: > NoQ wrote: > > This needed to go up because that's where `CLANG_ENABLE_STATIC_ANALYZER` is > > defined. > Let's add some scary comments then, to warn everyone trying to blindly > clang-format this file. I'd suggest to move all conditionally-included headers into a separate "section" below, separated by a newline from the rest of the headers. clang-format will respect that and won't reorder sections. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67419/new/ https://reviews.llvm.org/D67419 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
