This revision was automatically updated to reflect the committed changes.
Closed by commit rL370621: [ASTImporter] At import of records re-order indirect
fields too. (authored by balazske, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to comm
a_sidorin accepted this revision.
a_sidorin added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66866/new/
https://reviews.llvm.org/D66866
___
cfe-commits mailing list
cfe-commits@list
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66866/new/
https://reviews.llvm.org/D66866
balazske updated this revision to Diff 217816.
balazske added a comment.
- Simplified field matcher in tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66866/new/
https://reviews.llvm.org/D66866
Files:
clang/lib/AST/ASTImporter.cpp
clang/u
martong added a comment.
Looks good, I just have a comment about the matcher.
Comment at: clang/unittests/AST/ASTImporterTest.cpp:1434
+AST_MATCHER_P(RecordDecl, hasFieldIndirectFieldOrder, std::vector,
+ Order) {
This name sounds strange for me,
balazske created this revision.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
Correct order of fields and indirect fields in imported RecordD
