[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin marked an inline comment as done. kmclaughlin added a subscriber: ruiu. kmclaughlin added a comment. Thank you to @gribozavr & @ruiu for spotting the warning caused by this patch, and the suggestions to use -Wimplicit-fallthrough! Comment at: llvm/trunk/lib/Target/

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

gribozavr added inline comments. Comment at: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp:5836-5837 if (VT.getSizeInBits() == 128) return std::make_pair(0U, &AArch64::FPR128_loRegClass); +case 'y': + if (!Subtarget->hasFPARMv8())

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

This revision was automatically updated to reflect the committed changes. Closed by commit rL370673: [SVE][Inline-Asm] Support for SVE asm operands (authored by kmclaughlin, committed by ). Changed prior to commit: https://reviews.llvm.org/D66302?vs=216655&id=218376#toc Repository: rL LLVM

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks for making these changes @kmclaughlin, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302 _

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin updated this revision to Diff 216655. kmclaughlin added a comment. - Removed a confusing comment from AArch64AsmPrinter.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302 Files: docs/LangRef.rst lib/Target/AArch64/AArch64AsmPrin

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin updated this revision to Diff 216574. kmclaughlin added a comment. - Changed printAsmRegInClass in AArch64AsmPrinter.cpp to accept //unsigned AltName// instead of //bool isVector// - Added a comment to explain the test in aarch64-sve-asm-negative.ll CHANGES SINCE LAST ACTION https

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

sdesmalen added inline comments. Comment at: lib/Target/AArch64/AArch64AsmPrinter.cpp:618 +bool hasAltName; +const TargetRegisterClass *RegClass; The use of `hasAltName` is confusing me here. When I look at the declaration and definition of `printAsmRe

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin updated this revision to Diff 216178. kmclaughlin added a comment. - Added a new test file, aarch64-sve-asm-negative.ll - Updated description of the 'y' constraint in LangRef.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66302/new/ https://reviews.llvm.org/D66302 File

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

sdesmalen added a comment. Thanks for this change @kmclaughlin. Comment at: docs/LangRef.rst:3816 +- ``x``: Like w, but restricted to registers 0 to 15 inclusive. +- ``y``: Like w, but restricted to registers 0 to 7 inclusive. I noticed this comment does not

[PATCH] D66302: [SVE][Inline-Asm] Support for SVE asm operands

kmclaughlin created this revision. kmclaughlin added reviewers: t.p.northover, sdesmalen, rovka, momchil.velikov. Herald added subscribers: psnobl, rkruppe, tschuett, javed.absar. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following inline asm constraints for SVE: -