kmclaughlin marked an inline comment as done.
kmclaughlin added a subscriber: ruiu.
kmclaughlin added a comment.
Thank you to @gribozavr & @ruiu for spotting the warning caused by this patch,
and the suggestions to use -Wimplicit-fallthrough!
================
Comment at: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp:5836-5837
if (VT.getSizeInBits() == 128)
return std::make_pair(0U, &AArch64::FPR128_loRegClass);
+ case 'y':
+ if (!Subtarget->hasFPARMv8())
----------------
gribozavr wrote:
> ```
> AArch64ISelLowering.cpp:5837:5: warning: unannotated fall-through between
> switch labels [-Wimplicit-fallthrough]
> AArch64ISelLowering.cpp:5837:5: note: insert 'LLVM_FALLTHROUGH;' to silence
> this warning
> AArch64ISelLowering.cpp:5837:5: note: insert 'break;' to avoid fall-through
> ```
>
> Is the fallthrough intentional?
The fallthrough was not intentional; this should now be resolved by D67095
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66302/new/
https://reviews.llvm.org/D66302
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
