[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL369349: [clangd] Skip function bodies inside processed files while indexing (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 216073. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Change /// to // Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66226/new/ https://reviews.llvm.org/D66226 Files:

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:194 CI.getDiagnostics().setIgnoreAllWarnings(true); +/// Instruct the parser to ask our ASTConsume

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745 +bool SymbolCollector::shouldProcessFile(FileID FID) { + assert(ASTCtx); kadircet wrote: > we already have `

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 216066. ilya-biryukov added a comment. - Expose the existing helper instead of introducing a new one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66226/new/ https://reviews.llvm.org/D66226 Files: clan

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. This looks great, thanks! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:745 +bool SymbolCollector::shouldProcessFile(FileID FID) { + assert(ASTCtx); we already have `shouldIndexFile` as an anonymous function inside

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

2019-08-14 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. This significantly improves performance of background indexing. We do not collect references and declarations inside the pr