This revision was automatically updated to reflect the committed changes.
Closed by commit rL364392: [clangd] Don't rename the namespace. (authored
by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137
+// Parsing the .h file as C++ include.
+TU.ExtraArgs.push_back("-xobjective-c++-header");
auto AST = TU.build();
sammccall wrote:
> hokein wrote:
> > sa
hokein updated this revision to Diff 206437.
hokein marked an inline comment as done.
hokein added a comment.
Verify the error message in the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63759/new/
https://reviews.llvm.org/D63759
Files:
c
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137
+// Parsing the .h file as C++ include.
+TU.ExtraArgs.push_back("-xobjective-c++-header");
auto AST = TU.build();
hokein wrote:
> sammccall wrote:
> >
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137
+// Parsing the .h file as C++ include.
+TU.ExtraArgs.push_back("-xobjective-c++-header");
auto AST = TU.build();
sammccall wrote:
> (why this change?)
f
hokein updated this revision to Diff 206412.
hokein marked 3 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63759/new/
https://reviews.llvm.org/D63759
Files:
clang-tools-ex
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:167
+ case UnsupportedSymbol:
+return "not a supported symbol (e.g. namespace)";
}
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
Also fix a small bug -- the extra argument "-xc++" doesn't overwrite the
language if the argument is present after the fil
