aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r363820; we'll look into integrating the script into lit as you
suggested for a possible follow-up.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63490/new/
https://reviews.llvm.org/D63490
__
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thanks!
I think we can maybe make this a little more convenient to use. For the
non-JSON `-ast-dump` format, I added `utils/make-ast-dump-check.sh` which can
be used as (for example):
$ li
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
Trying to write or maintain test code for AST dumping of JSON information can
be onerous due to small changes in the test requiring a large amount of line
numbers or other information to be updated in the expected test