rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Thanks!

I think we can maybe make this a little more convenient to use. For the 
non-JSON `-ast-dump` format, I added `utils/make-ast-dump-check.sh` which can 
be used as (for example):

  $ lit -DFileCheck=$PWD/utils/make-ast-dump-check.sh test/AST/ast-dump-openmp-*

That is: run the tests, and instead of piping their output through `FileCheck`, 
run it through a script that converts the actual output into test expectations. 
That way, the script doesn't need to run `clang` (or know what command-line 
arguments would be used to do so); `lit` does that for you. I don't think that 
approach would be able to provide your `--filters` flag, but maybe that could 
be passed in as part of the `-D`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63490/new/

https://reviews.llvm.org/D63490



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D63490: S... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D634... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D634... Aaron Ballman via Phabricator via cfe-commits

Reply via email to